Raise exception on calling `SqlClientFactory.Instance` from facade assembly

[PatrickHofman]

Describe the bug

The Microsoft.Data.SqlClient.dll assembly that is copied to the output folder on a build contains stubs that throw a PlatformNotSupportedException with the text "Microsoft.Data.SqlClient is not supported on this platform." on all relevant methods. This is intended since the correct assembly and its dependencies are loaded from the runtimes folder.

However, if this assembly loading from the runtimes folder does not succeed, for example when the deps.json file omits the correct runtimeTargets, the facade assembly is used.

As said, the assembly usually throws an exception on all methods, but not on calling the SqlClientFactory.Instance field. Although this field is marked not to be null, it is when only loading the facade assembly.

This results in a NullReferenceException on calling SqlClientFactory.Instance.CreateConnection() and others.

To reproduce

• Create a console application;
• Add the Microsoft.Data.SqlClient NuGet package;
• Add this line of code SqlClientFactory.Instance.CreateConnection();
• Build;
• Open the [app].deps.json file using Notepad and remove "runtimeTargets" under "Microsoft.Data.SqlClient/7.0.0";
• Run the application;
• A NullReferenceException is thrown.

Expected behavior

A clear exception, for example by converting Instance to a property and throw an exception, or throw the exception from a static constructor.

Further technical details

Microsoft.Data.SqlClient version: 7.0.0
.NET target: .NET 10.0

[monty241]

Possibly problems caused by returning the somewhat vague `nul`` instead of an actionable error:

• Null reference on Microsoft.Data.SqlClient.SqlClientFactory.Instance if loaded using Assembly.LoadFrom() in AppDomain.CurrentDomain.AssemblyResolve delegate #2064
• https://stackoverflow.com/questions/73681010/microsoft-data-sqlclient-sqlclientfactory-instance-null
• https://stackoverflow.com/questions/75888139/issue-when-trying-to-register-a-microsoft-data-sqlclient-sqlclientfactory-instan
• https://errorism.dev/issues/dotnet-sqlclient-null-reference-on-microsoftdatasqlclientsqlclientfactoryinstance-if-loaded-using-assemblyloadfr

[priyankatiwari08]

Thank you for reporting this. I'm looking into this issue and will follow up with a fix.