Current Behavior
When trying to run the Fortify GitHub Action on GitHub Enterprise Server (GHES), it will fail due to actions/upload-artifact@v4 not being supported on GHES: https://github.com/marketplace/actions/upload-a-build-artifact#v4---whats-new
Expected Behavior
The Fortify GitHub Action should run successfully on both github.com and GHES.
Steps To Reproduce
Just attempt to run the Fortify GitHub Action on GHES
Anything else?
There are currently 4 places where we use actions/upload-artifact@v4:
fod-export & ssc-export: Always try to upload SARIF file for debugging purposes
package: Upload package & logs if DO_PACKAGE_DEBUG is set to true
Some potential work-arounds:
- Use
actions/upload-artifact@v3 instead for the time being, but this will likely fail on github.com as stated here: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
- Create an
internal/upload-artifact sub-action that automatically selects between v3 and v4 of actions/upload-artifact depending on whether the action is running in GHES (or maybe there's already such an action publicly available?), then use that action for uploading debug artifacts. Main drawback is that GitHub downloads all referenced actions when a job starts, so we'd always be downloading both versions of actions/upload-artifact.
- Don't upload artifacts when running on GHES, however this means losing debugging capabilities.
- Create separate Fortify GitHub Actions for github.com and GHES
Current Behavior
When trying to run the Fortify GitHub Action on GitHub Enterprise Server (GHES), it will fail due to
actions/upload-artifact@v4not being supported on GHES: https://github.com/marketplace/actions/upload-a-build-artifact#v4---whats-newExpected Behavior
The Fortify GitHub Action should run successfully on both github.com and GHES.
Steps To Reproduce
Just attempt to run the Fortify GitHub Action on GHES
Anything else?
There are currently 4 places where we use
actions/upload-artifact@v4:fod-export&ssc-export: Always try to upload SARIF file for debugging purposespackage: Upload package & logs ifDO_PACKAGE_DEBUGis set totrueSome potential work-arounds:
actions/upload-artifact@v3instead for the time being, but this will likely fail on github.com as stated here: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/internal/upload-artifactsub-action that automatically selects betweenv3andv4ofactions/upload-artifactdepending on whether the action is running in GHES (or maybe there's already such an action publicly available?), then use that action for uploading debug artifacts. Main drawback is that GitHub downloads all referenced actions when a job starts, so we'd always be downloading both versions ofactions/upload-artifact.