Skip to content

Git credentials hardcoded in aliases.sh overwrites user identity #11

@jellygator

Description

@jellygator

Issue Description

Hi Will! First, thanks for sharing these dotfiles - they're really well organized.

I think I've discovered an issue where installing these dotfiles overwrites the user's git identity with your personal credentials.

Disclaimer

I've got zero dev background, mostly just tinkering and breaking my computer over and over, so please let me know if I'm just missing something really obvious. It might be nothing...

The Problem

In /shell/common/aliases.sh (lines 153-155), there are hardcoded git config commands:

git config --global user.name "Will Cygan"
git config --global user.email "wcygan.io@gmail.com"
git config --global core.editor "vim"

These commands run every time a shell starts, causing anyone who installs your dotfiles to make git commits under your name
instead of their own.

Impact

  • All git commits are attributed to "Will Cygan" instead of the actual user
  • Affects GitHub contribution graphs and commit history
  • Users might not notice until after making several commits

Suggested Fix

Replace the hardcoded values with commented examples:

Git configuration - customize with your own information

git config --global user.name "Your Name"

git config --global user.email "your.email@example.com"

git config --global core.editor "vim"

Or move these to a separate git-config-example.sh file that users can customize.

Or IDK - run code that will replicate existing user details in the terminal to the dotfiles when installing.

Steps to Reproduce

Brew instllation on Mac terminal - pretty standard as per your readme

  1. Clone and install the dotfiles: deno task install
  2. Open a new terminal
  3. Run git config --global user.name
  4. Result: Shows "Will Cygan" instead of the user's name

Thanks for maintaining this project!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions