core/state: fix GetWriteMapDump write-set output#2156
Open
AaronAjose wants to merge 1 commit into0xPolygon:developfrom
Open
core/state: fix GetWriteMapDump write-set output#2156AaronAjose wants to merge 1 commit into0xPolygon:developfrom
AaronAjose wants to merge 1 commit into0xPolygon:developfrom
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review.
Tip: disable this comment in your organization's Code Review settings.
|
manav2401
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• # Description
This PR fixes
GetWriteMapDumpso it emits the actual MV write set instead of incorrectly reusing the read set, and adds a regression test to keep the read/write dump semantics correct for block-stm IO tracing.Changes
Nodes audience
Not applicable. This change is not limited to a subset of nodes and does not introduce any new flag or rollout condition.
Checklist
Cross repository changes
Testing
Additional comments
Automated validation executed for this change:
go test ./core/state -run "TestDumpMapsUseCorrectReadWriteSets|TestMVHashMapReadWriteDelete"go test ./core/statego test ./eth/tracers -run TestTraceBlockgo test ./eth/tracersgo vet ./core/state ./eth/tracers