Skip to content

fix: implement time validation in createElection #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArshLabs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: implement time validation in createElection #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion blockchain/contracts/ElectionFactory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ contract ElectionFactory is CCIPReceiver {
error OwnerRestricted();
error NotWhitelistedSender();
error InvalidCandidatesLength();
error InvalidStartTime();
error InvalidEndTime();

struct CCIPVote {
address election;
Expand Down Expand Up @@ -61,7 +63,8 @@ contract ElectionFactory is CCIPReceiver {
uint _resultType
) external {
if (_candidates.length<2) revert InvalidCandidatesLength();
//add checks of time
if (_electionInfo.startTime <= block.timestamp) revert InvalidStartTime();
if (_electionInfo.endTime <= _electionInfo.startTime) revert InvalidEndTime();
address electionAddress = Clones.clone(electionGenerator);
address _ballot = ballotGenerator.generateBallot(
_ballotType,
Expand Down