fix: relax scipy version constraint for Windows Python 3.9 compatibility#613
fix: relax scipy version constraint for Windows Python 3.9 compatibility#613Satyanarayana001 wants to merge 2 commits intoAOSSIE-Org:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
requirements.txt (1)
8-8: Consider adding an upper bound to scipy for improved stability.The change from a pinned version to
scipy>=1.11.0successfully resolves the Windows Python 3.9 installation issue. SciPy 1.11.0 wheels are available for Python 3.9 Windows, and it satisfies scikit-learn 1.5.2's dependency requirement (scipy>=1.6.0).However, without an upper bound, future scipy releases could introduce unexpected behavior. Since most other dependencies in requirements.txt are pinned to specific versions, consider constraining scipy with
scipy>=1.11.0,<2.0.0to balance flexibility with reproducibility.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@requirements.txt` at line 8, Update the scipy requirement in requirements.txt from a loose lower-bound to a constrained range to prevent future-breaking upgrades; change the entry for "scipy" (the existing scipy>=1.11.0 line) to include an upper bound such as "scipy>=1.11.0,<2.0.0" so you retain the fix for Python 3.9 while preserving reproducibility.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@requirements.txt`:
- Line 8: Update the scipy requirement in requirements.txt from a loose
lower-bound to a constrained range to prevent future-breaking upgrades; change
the entry for "scipy" (the existing scipy>=1.11.0 line) to include an upper
bound such as "scipy>=1.11.0,<2.0.0" so you retain the fix for Python 3.9 while
preserving reproducibility.
|
@Satyanarayana001 |
Fixes #382
Problem
scipy==1.14.0 is not available for Python 3.9 on Windows,
blocking backend setup for contributors.
Fix
Relaxed scipy version constraint from ==1.14.0 to >=1.11.0
allowing pip to install the best compatible version automatically.
Summary by CodeRabbit