Per-command Discord slash permissions, optional testing bypass, Docker defaults, and repo allowlist#9
Closed
shubham5080 wants to merge 2 commits intomainfrom
Closed
Conversation
Remove accidentally committed .pydeps/, .venv2/, and package-lock.json. These are local Python/npm artifacts and should not be in the repo. Made-with: Cursor
Contributor
|
Important Review skippedToo many files! This PR contains 295 files, which is 145 over the limit of 150. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (295)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
no-issue-linked
backend
python
tests
size/XL
external-contributor
and removed
size/XL
labels
shubham5080
deleted the
feature/discord-command-permissions-docker-repo-filter
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-command Discord slash permissions, optional testing bypass, Docker defaults, and repo allowlist
Summary
Adds configurable who may run
/assign-issue,/issue-requests, and/syncviadiscord.command_permissions, with legacy fallback toassignments.issue_assigneeswhen a command is not listed. Includes a testing-only flag to allow any guild member to run those commands, Docker-oriented config defaults, an example GitHub repo allowlist for faster sync, and unit tests for the permission helpers.Behavior
discord.command_permissions: map command names (assign-issue,issue-requests,sync) to rules withrole_ids,role_names, and optionalallow_discord_administrators.discord.unrestricted_slash_commands: whentrue, skips permission checks for those commands (intended for short-lived testing; leavefalsein production).command_permissions, behavior matches the previous mentor / issue_assignees rule.Config & ops
docker-compose: default command points at/app/config/aussie.yaml(adjust as needed).config/config.yaml:data_dirset for Docker volume use where applicable.example.yaml,docker-example.yaml,aussie.yaml) document the new Discord fields;github.reposallowlist example limits which repos are synced.Tests
tests/test_discord_command_permissions.pycovers allow/deny, admin bypass, unrestricted mode, and legacy fallback.Cleanup
.pydeps/,.venv2/, straypackage-lock.json) and extends.gitignoreso they are not committed again.