Skip to content

fix: Factory Tech issues#381

Open
Wizzerinus wants to merge 2 commits intoCleanroomMC:masterfrom
TeamDimensional:fix/factorytech-input-multipliers
Open

fix: Factory Tech issues#381
Wizzerinus wants to merge 2 commits intoCleanroomMC:masterfrom
TeamDimensional:fix/factorytech-input-multipliers

Conversation

@Wizzerinus
Copy link
Copy Markdown
Contributor

This PR fixes the following issues with Factory Tech compatibility:

  • Removes Circuit Scribe integration, because it does not actually work. The tile entity determines if Circuit Scribe can work by comparing its input item with circuit_intermediate:0 and its output item with circuit_intermediate:X, which means custom recipes can't be added. (see https://gitlab.com/dalapo/FactoryTech/-/blob/master/src/main/java/dalapo/factech/tileentity/specialized/TileEntityCircuitScribe.java)
  • Removes getMaxItemInput from the machines that properly handle item input size. These machines are Centrifuge, Magnet Centrifuge, Grindstone, High Tech Furnace, Magnetizer, Metal Cutter, Ore Drill, Reclaimer, Saw. The other machines fail in different ways when item input size != 1 (either requiring X but only consuming 1 item, consuming X but running with < X, or both).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe make a comment about the circuit scribe?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants