Open
Conversation
WaitingIdly
approved these changes
Apr 11, 2026
Collaborator
There was a problem hiding this comment.
maybe make a comment about the circuit scribe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues with Factory Tech compatibility:
circuit_intermediate:0and its output item withcircuit_intermediate:X, which means custom recipes can't be added. (see https://gitlab.com/dalapo/FactoryTech/-/blob/master/src/main/java/dalapo/factech/tileentity/specialized/TileEntityCircuitScribe.java)getMaxItemInputfrom the machines that properly handle item input size. These machines areCentrifuge, Magnet Centrifuge, Grindstone, High Tech Furnace, Magnetizer, Metal Cutter, Ore Drill, Reclaimer, Saw. The other machines fail in different ways when item input size != 1 (either requiring X but only consuming 1 item, consuming X but running with < X, or both).