Open
Conversation
There was a problem hiding this comment.
Pull request overview
Improves client-v2 error handling by enriching binary reader decode exceptions with context (row/column and elapsed time since last next() call) and by surfacing HTTP error response bodies for common non-ClickHouse errors (e.g., 401/403/404), addressing opaque <Unreadable error message> failures (Issue #2803).
Changes:
- Enhance
RowBinaryreader failures with row/column context and time since lastnext()call. - Parse and include HTTP error response bodies for 401/403/404 (including gzip-encoded bodies) instead of reporting code
0with no message. - Add integration tests covering 404 base-path handling and truncated/chunked binary decode failures.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| client-v2/src/test/java/com/clickhouse/client/HttpTransportTests.java | Adds integration tests for 404 body propagation and improved binary decode failure reporting. |
| client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java | Refactors error parsing to include non-ClickHouse HTTP error bodies and adjusts compression wrapping for 404. |
| client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java | Adds row/column + elapsed-time context to binary reader exceptions. |
| clickhouse-data/src/main/java/com/clickhouse/data/ClickHouseColumn.java | Adds helper to format column index + name for improved error messages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Show resolved
Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java
Outdated
Show resolved
Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java
Show resolved
Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java
Show resolved
Hide resolved
client-v2/src/test/java/com/clickhouse/client/HttpTransportTests.java
Outdated
Show resolved
Hide resolved
client-v2/src/main/java/com/clickhouse/client/api/internal/HttpAPIClientHelper.java
Outdated
Show resolved
Hide resolved
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IOExceptionwhen reading data inRowBinaryreaders. Now time difference between error and lastnext()call is reported. Also row and column is reported .0and no message was copied from body.Closes #2803
Closes #2764
Checklist
Delete items not relevant to your PR: