Skip to content

Manchester | 26-ITP-Jan | Ofonime Edak | Sprint 3 | Quote-generator#1135

Open
Ofonimeedak wants to merge 2 commits intoCodeYourFuture:mainfrom
Ofonimeedak:quote-generator
Open

Manchester | 26-ITP-Jan | Ofonime Edak | Sprint 3 | Quote-generator#1135
Ofonimeedak wants to merge 2 commits intoCodeYourFuture:mainfrom
Ofonimeedak:quote-generator

Conversation

@Ofonimeedak
Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Add JS code to quote.js to make the HTML code interactive

@Ofonimeedak Ofonimeedak added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Mar 28, 2026
@Luro91 Luro91 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 6, 2026
Copy link
Copy Markdown

@Luro91 Luro91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should the title of the html page be set to?

displayAuthor.textContent = myQuotes.author;
}

btn.addEventListener("click", quoteGenerator);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a random quote when the page loads

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review I will update this functionality and commit Asap

@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 6, 2026
@Ofonimeedak
Copy link
Copy Markdown
Author

Please kindly review my latest commit, thank you

@Ofonimeedak Ofonimeedak requested a review from Luro91 April 7, 2026 03:49
@Ofonimeedak Ofonimeedak added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 7, 2026
@Luro91
Copy link
Copy Markdown

Luro91 commented Apr 7, 2026

Looks good now. Well done

@Luro91 Luro91 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants