Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3| Sprint3 /Quote generator#1163
Open
marthak1 wants to merge 5 commits intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3| Sprint3 /Quote generator#1163marthak1 wants to merge 5 commits intoCodeYourFuture:mainfrom
marthak1 wants to merge 5 commits intoCodeYourFuture:mainfrom
Conversation
marthak1
added
the
Needs Review
cjyuan
reviewed
Apr 3, 2026
Comment on lines
+492
to
+493
| const title = document.querySelector("title") | ||
| title.textContent = "Quote generator app"; |
Contributor
There was a problem hiding this comment.
Why not just set the title in HTML?
Comment on lines
+507
to
+510
| displayQuote(); | ||
|
|
||
| // Change quote when button is clicked | ||
| button.addEventListener("click", displayQuote); No newline at end of file |
Contributor
There was a problem hiding this comment.
Placing all the "run on load" code in one place is a good practice.
Would be even better to place the code
inside a function to make it clearer that "this is what runs when the page loads."
For examples,
function setup() {
// code to be executed on page load
}
window.addEventListener('load', setup);or
window.addEventListener('load', function() {
// code to be executed on page load
});
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Built quote generator app as per assignment requirements