Skip to content

Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3| Reading List#1171

Open
marthak1 wants to merge 7 commits intoCodeYourFuture:mainfrom
marthak1:sprint-3/readinglist
Open

Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3| Reading List#1171
marthak1 wants to merge 7 commits intoCodeYourFuture:mainfrom
marthak1:sprint-3/readinglist

Conversation

@marthak1
Copy link
Copy Markdown

@marthak1 marthak1 commented Apr 3, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Built reading a book reading list

@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 3, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 3, 2026
@github-actions

This comment has been minimized.

@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 3, 2026
@Edu-Vin Edu-Vin added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 4, 2026
@Edu-Vin
Copy link
Copy Markdown

Edu-Vin commented Apr 4, 2026

Well done on listing the books on the dom. There are still some issues.

  • The instructions say the title element in the index.html file should be updated.
  • Your UI does not match the design in the readme file. The books are supposed to be listed vertically with a margin between each book.

I will advise you not to dump the book title in the li, but wrap it in an element inside the li, best case a p tag.

@Edu-Vin Edu-Vin added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants