Skip to content

fix: drop support for EdDSA keys #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aldbr wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −3
Open

fix: drop support for EdDSA keys #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions diracx-core/src/diracx/core/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,7 @@ def check_retention_greater_than_expiration(self) -> Self:
generation and verification.
"""

# TODO: EdDSA should be removed later due to "SecurityWarning: EdDSA is deprecated via RFC 9864"
token_allowed_algorithms: list[str] = ["RS256", "EdDSA", "Ed25519"] # noqa: S105
token_allowed_algorithms: list[str] = ["RS256", "Ed25519"] # noqa: S105
"""List of allowed cryptographic algorithms for JWT token signing.

Supported algorithms include RS256 (RSA with SHA-256) and Ed25519
Expand Down
2 changes: 1 addition & 1 deletion docs/admin/reference/env-variables.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ generation and verification.

### `DIRACX_SERVICE_AUTH_TOKEN_ALLOWED_ALGORITHMS`

*Optional*, default value: `['RS256', 'EdDSA', 'Ed25519']`
*Optional*, default value: `['RS256', 'Ed25519']`

List of allowed cryptographic algorithms for JWT token signing.

Expand Down
Loading