clang-tidy: resolve bugprone-return-const-ref-from-parameter

[greenc-FNAL]

All existing ocurrences were intentional, and have been marked as such with NOLINT.

[Copilot]

Pull request overview

This PR addresses clang-tidy’s bugprone-return-const-ref-from-parameter findings by explicitly marking intentional “return-by-const-ref” patterns with NOLINT in a few small helper functions used across the model/core layers.

Changes:

• Add // NOLINT(bugprone-return-const-ref-from-parameter) to intentional return-by-const-ref sites in more_derived(...) helpers.
• Add the same suppression to an internal maybe_name(...) helper that returns either a static sentinel or the input string.
• Reformat a couple of one-line inline overloads into multi-line bodies while adding the suppression.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
phlex/model/product_store.hpp	Adds suppression for the single-arg most_derived overload (but currently placed in a way that likely won’t suppress the warning).
phlex/model/product_store.cpp	Adds NOLINT to the two return statements in more_derived(...).
phlex/model/data_layer_hierarchy.cpp	Adds NOLINT to the ternary return in maybe_name(...).
phlex/core/message.hpp	Rewrites the single-arg most_derived overload into multi-line form and adds NOLINT to the return.
phlex/core/message.cpp	Adds NOLINT to the two return statements in more_derived(...).

[codecov]

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
phlex/core/message.cpp	50.00%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
+ Coverage   85.57%   85.62%   +0.05%     
==========================================
  Files         142      142              
  Lines        3604     3604              
  Branches      616      616              
==========================================
+ Hits         3084     3086       +2     
+ Misses        310      309       -1     
+ Partials      210      209       -1     

Flag	Coverage Δ
unittests	85.62% <85.71%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
phlex/core/message.hpp	100.00% <100.00%> (ø)
phlex/model/data_layer_hierarchy.cpp	100.00% <100.00%> (ø)
phlex/model/product_store.cpp	83.33% <100.00%> (ø)
phlex/model/product_store.hpp	100.00% <100.00%> (ø)
phlex/core/message.cpp	41.66% <50.00%> (-8.34%)	⬇️

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51fc599...8351e26. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.