Add tests for calibration module#209
Open
PrasannaPal21 wants to merge 3 commits intoGliderToolsCommunity:masterfrom
Open
Add tests for calibration module#209PrasannaPal21 wants to merge 3 commits intoGliderToolsCommunity:masterfrom
PrasannaPal21 wants to merge 3 commits intoGliderToolsCommunity:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the dummy test in
test_calibration.pywith actual tests for all 4 functions in the calibration module.bottle_matchup- tests for a match, no match(time), no match(depth)model_metrics- checks output keys and values on the known linear fitmodel_figs- checks that it returns an axes without crashingrobust_linear_fit- checks fitted slope, NaN handling for predict and error when all calibration data is NaNCloses #208
Tests added
Passes pre-commit run --all-files