Fix ATOF and AHDC issues: Remove CalibrationConstantsLoader, use IndexedTable directly for AHDC/ATOF calibration#1200
Merged
baltzell merged 5 commits intodevelopmentfrom Apr 10, 2026
Merged
Conversation
Instead of replacing static maps with instance maps, we remove the intermediate layer entirely. Each engine now stores IndexedTable references fetched directly from ConstantsManager (which already caches per run with proper synchronization). Consumer code queries tables via getDoubleValue("column", sector, layer, component) or getDoublesByHash() for bulk access.
mathieuouillon
requested review from
N-Plx,
baltzell,
ftouchte,
mpaolone and
whit2333
This was
linked to
issues
Apr 9, 2026
baltzell
previously approved these changes
Apr 9, 2026
Collaborator
|
@mathieuouillon I really like this new implementation. Could you also load the |
ftouchte
previously approved these changes
Apr 10, 2026
Register /calibration/alert/ahdc/gains in ALERTEngine's init() and refresh the IndexedTable reference on run change, so it is available for downstream use. Requested by @ftouchte for an upcoming pull request.
baltzell
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove CalibrationConstantsLoader and its static mutable state. Engines now fetch IndexedTable references directly from ConstantsManager and pass them to consumer code. This fixes three bugs:
Simplify calibration access: consumer code (HitReader, ATOFHit, BarHit) queries IndexedTable directly via getDoubleValue("column", sector, layer, component). No manual key encoding, no intermediate maps
Separate AHDC/ATOF table requirements: each engine's init() now only registers its own detector's CCDB tables
Fix IndexOutOfBoundsException in ALERTEngine when a track has no matching hits in AHDC::hits
Clean up mode config parsing in AHDCEngine using ModeTrackFinding.valueOf()
Related to issues: #1182 and #1183