libxo/*.h fix libxo header include when the source is C++#100
Open
aokblast wants to merge 1 commit intoJuniper:mainfrom
Open
libxo/*.h fix libxo header include when the source is C++#100aokblast wants to merge 1 commit intoJuniper:mainfrom
aokblast wants to merge 1 commit intoJuniper:mainfrom
Conversation
|
Could you explain why you are wanting the C++ magic on files like xo_private.h and xo_explicit.h? These are internal/private files and should never be included by external c++ files. Thanks, |
C++ needs extern C to disable C++ name mangling. To use libxo in C++ it is better to include extern "C" guardian
aokblast
force-pushed
the
fix_libxo_extern_c_include
branch
from
657d3d9 to
93dfdab
Compare
Author
|
Sorry for misuse extern "C" in code, I just try modifying all header until my code successfully compiled. Fix it right now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++ needs extern C to disable C++ name mangling.
To use libxo in C++ it is better to include extern "C" guardian