Skip to content

Merge Flow4D model into codebase#1

Merged
Kin-Zhang merged 7 commits intomainfrom
feature/flow4d
Mar 10, 2025
Merged

Merge Flow4D model into codebase#1
Kin-Zhang merged 7 commits intomainfrom
feature/flow4d

Conversation

@Kin-Zhang
Copy link
Copy Markdown
Member

@jykim94 Check if this pull request is ok, feel free to revise it through new commits on the feature/flow4d branch.

Could you also replace ? to your setting? Specific line in the README:

[Runtime: Around ? hours in ? GPUs.]

docs(conf): update flow4d README and conf
@Kin-Zhang Kin-Zhang requested a review from jykim94 February 18, 2025 18:46
@Kin-Zhang Kin-Zhang added the new method new method involve label Feb 26, 2025
@Kin-Zhang
Copy link
Copy Markdown
Member Author

Do you mind if I uploaded your weight provided to me before into huggingface? so people can directly wget easily? How do you think, Jaeyeul?

@jykim94
Copy link
Copy Markdown
Collaborator

jykim94 commented Mar 8, 2025

Do you mind if I uploaded your weight provided to me before into huggingface? so people can directly wget easily? How do you think, Jaeyeul?

Did I also provide you the Flow4D weights for Argoverse2? Currently, I don't have available pretrained weights for Argoverse2.
If you upload the Flow4D weights to Hugging Face, that would be great for me!

@Kin-Zhang
Copy link
Copy Markdown
Member Author

Kin-Zhang commented Mar 8, 2025

Yes, I think so (let me check) and I can convert to this codebase and send results here later.

Btw, I also add flow4d bib here. Hope you don't mind, let me know if anything wrong with the core code.

And if everything ok, you can approve the review then I will start squash and merge afterward once I check all docs are aligned.

* update README and delete useless info
* update bib on the end of readme but with link to jump at the beginning.
and ignore warning info for np in eval script.
@Kin-Zhang
Copy link
Copy Markdown
Member Author

Kin-Zhang commented Mar 10, 2025

Great, I found the weight! And here is the val score (while I will soon have another pull request to update scene flow ground truth things and it will update all methods' scores here)

image

I will update both the weight and the fixed flow gt demo in the hugging face today.\


If you find anything incorrect in the core script, feel free to create another pull request! Thanks again for contributing!

@Kin-Zhang Kin-Zhang merged commit f7e59aa into main Mar 10, 2025
@Kin-Zhang Kin-Zhang deleted the feature/flow4d branch March 10, 2025 07:44
@Kin-Zhang
Copy link
Copy Markdown
Member Author

A link for fixed gt and update all methods scores if interested: #5

@jykim94
Copy link
Copy Markdown
Collaborator

jykim94 commented Mar 13, 2025

A link for fixed gt and update all methods scores if interested: #5

Got it. Thank you for updating the Flow4D results as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new method new method involve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants