fix multitrack EQ preset logging and Firefox worker decode#163
Merged
mfwolffe merged 2 commits intoLab-Lab-Lab:mainfrom Apr 2, 2026
Merged
fix multitrack EQ preset logging and Firefox worker decode#163mfwolffe merged 2 commits intoLab-Lab-Lab:mainfrom
mfwolffe merged 2 commits intoLab-Lab-Lab:mainfrom
Conversation
Worker transfers fetched ArrayBuffer back to main thread for decoding instead of erroring out and triggering a re-fetch that may 503.
ClipEQ (multitrack EQ) is a separate component from EQ.js (single-track). It had no logOperation at all, so selecting Warm Bass in multitrack never logged eq_preset_applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClipEQ(multitrack EQ component) is separate fromEQ.js(single-track). It had nologOperationwired in, so selecting "Warm Bass" in multitrack never loggedeq_preset_applied, leaving Activity 3 Q5 permanently locked for multitrack users. PasseslogOperationthrough ClipEffectsRack → ClipEffectParametersModal → ClipEQ.OfflineAudioContextis unavailable in Web Workers on Firefox and Safari. Instead of erroring out and triggering a re-fetch (which may 503), the worker now transfers the already-fetched ArrayBuffer back to the main thread for decoding — zero-copy, no second network request.