MDEV-14373: Reject incompatible PLUGIN_xxx build mode at configure time#4872
Open
FaramosCZ wants to merge 1 commit intoMariaDB:10.11from
Open
MDEV-14373: Reject incompatible PLUGIN_xxx build mode at configure time#4872FaramosCZ wants to merge 1 commit intoMariaDB:10.11from
FaramosCZ wants to merge 1 commit intoMariaDB:10.11from
Conversation
gkodinov
added
the
External Contribution
FaramosCZ
force-pushed
the
MDEV-14373
branch
4 times, most recently
from
1d81a76 to
8cf1ca7
Compare
gkodinov
requested changes
Mar 31, 2026
Member
gkodinov
left a comment
gkodinov
left a comment
There was a problem hiding this comment.
Thank you for your contribution! This is a preliminary review.
LGTM. And makes a lot of sense too. But this is a bug fix. Please rebase to 10.11.
When a user sets -DPLUGIN_PARTITION=DYNAMIC or
-DPLUGIN_PERFSCHEMA=DYNAMIC, these plugins are declared
STATIC_ONLY in their CMakeLists.txt. Previously, the
MYSQL_ADD_PLUGIN macro would silently skip building such
plugins: the STATIC branch wouldn't match (because the user
requested DYNAMIC), and the DYNAMIC branch would be blocked
by ARG_STATIC_ONLY. The plugin was simply not built.
This caused confusing downstream compile errors in other
plugins that depended on the missing one:
- PLUGIN_PARTITION=DYNAMIC -> CONNECT fails:
'struct TABLE_SHARE' has no member named
'partition_info_str_len'
'struct TABLE' has no member named 'part_info'
- PLUGIN_PERFSCHEMA=DYNAMIC -> MariaBackup fails:
'MY_WME' was not declared in this scope
'my_read' was not declared in this scope
'MY_FILE_ERROR' was not declared in this scope
- PLUGIN_ARIA=DYNAMIC -> Spider fails:
'MARIA_COLUMNDEF' has not been declared
(Note: Aria is now MANDATORY and already overrides
user input; this was likely reproducible in older
versions where Aria was DEFAULT)
Root cause: The MYSQL_ADD_PLUGIN macro in
cmake/plugin.cmake did not validate that the
user-requested build mode (STATIC or DYNAMIC) was
compatible with the plugin's declared capabilities
(STATIC_ONLY or MODULE_ONLY).
Fix: Add validation immediately after the existing
PLUGIN_xxx value check. If DYNAMIC is requested for a
STATIC_ONLY plugin, or STATIC is requested for a
MODULE_ONLY plugin, emit a FATAL_ERROR with a clear
message telling the user which option to use instead.
Non-MANDATORY plugins with STATIC_ONLY (the new check
catches -DPLUGIN_xxx=DYNAMIC for these):
- partition (sql/CMakeLists.txt)
- perfschema (storage/perfschema/CMakeLists.txt)
- thread_pool_info (sql/CMakeLists.txt)
Conditionally STATIC_ONLY (platform/config-dependent):
- feedback (only on Windows)
The MANDATORY + STATIC_ONLY plugin sql_sequence is
unaffected: the MANDATORY flag overrides user input to
YES before the new check runs.
MODULE_ONLY plugins (the new check catches
-DPLUGIN_xxx=STATIC for these) include all dynamically-
loaded plugins: federated, spider, rocksdb, mroonga,
oqgraph, example, and ~25 others under plugin/ and
storage/.
The YES and AUTO modes are unaffected since they already
gracefully fall through to whichever mode the plugin
supports.
Co-Authored-By: Claude AI <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user sets -DPLUGIN_PARTITION=DYNAMIC or
-DPLUGIN_PERFSCHEMA=DYNAMIC, these plugins are declared STATIC_ONLY in their CMakeLists.txt. Previously, the MYSQL_ADD_PLUGIN macro would silently skip building such plugins: the STATIC branch wouldn't match (because the user requested DYNAMIC), and the DYNAMIC branch would be blocked by ARG_STATIC_ONLY. The plugin was simply not built.
This caused confusing downstream compile errors in other plugins that depended on the missing one:
PLUGIN_PARTITION=DYNAMIC -> CONNECT fails: 'struct TABLE_SHARE' has no member named 'partition_info_str_len' 'struct TABLE' has no member named 'part_info'
PLUGIN_PERFSCHEMA=DYNAMIC -> MariaBackup fails: 'MY_WME' was not declared in this scope 'my_read' was not declared in this scope 'MY_FILE_ERROR' was not declared in this scope
PLUGIN_ARIA=DYNAMIC -> Spider fails: 'MARIA_COLUMNDEF' has not been declared (Note: Aria is now MANDATORY and already overrides user input; this was likely reproducible in older versions where Aria was DEFAULT)
Root cause: The MYSQL_ADD_PLUGIN macro in
cmake/plugin.cmake did not validate that the
user-requested build mode (STATIC or DYNAMIC) was
compatible with the plugin's declared capabilities (STATIC_ONLY or MODULE_ONLY).
Fix: Add validation immediately after the existing PLUGIN_xxx value check. If DYNAMIC is requested for a STATIC_ONLY plugin, or STATIC is requested for a
MODULE_ONLY plugin, emit a FATAL_ERROR with a clear message telling the user which option to use instead.
Affected plugins with STATIC_ONLY:
Affected plugins with MODULE_ONLY:
The YES and AUTO modes are unaffected since they already gracefully fall through to whichever mode the plugin supports.