fix: filter extraneous VKey witnesses + add CI smoke test system#217
Merged
fix: filter extraneous VKey witnesses + add CI smoke test system#217
Conversation
Fix InvalidWitnessesUTXOW error on ballot vote submission by filtering witnesses whose key hash is not required by any native script in the transaction. Also adds defense-in-depth recovery in submitTxWithScriptRecovery. Create real-chain CI smoke system (issue #213) with 3 stages: - Stage 1: Bootstrap wallets from mnemonic secrets - Stage 2: Run 9 scenario tests against v1 API routes - Stage 3: Produce JSON report artifacts Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The workflow now checks for SMOKE_* secrets before running and skips cleanly if they are missing. The bootstrap script also exits 0 with a message instead of failing. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InvalidWitnessesUTXOW: Filter VKey witnesses after signing to remove keys not required by any native script in the transaction. This prevents Conway ledger rejection when wallets return extraneous witnesses during partial signing (e.g. ballot votes with both payment + DRep scripts).submitTxWithScriptRecoverynow also handlesInvalidWitnessesUTXOWby stripping offending witnesses and retrying submission.Test plan
npm run buildpasses (verified)InvalidWitnessesUTXOWSMOKE_API_BASE_URL,SMOKE_SIGNER_MNEMONIC_1,SMOKE_SIGNER_MNEMONIC_2,SMOKE_BOT_MNEMONIC,SMOKE_BOT_KEY_ID,SMOKE_BOT_SECRET)🤖 Generated with Claude Code