Set and restore the flipped geometry flag#326
Open
TomCarey wants to merge 3 commits intoMortimerGoro:masterfrom
Open
Set and restore the flipped geometry flag#326TomCarey wants to merge 3 commits intoMortimerGoro:masterfrom
TomCarey wants to merge 3 commits intoMortimerGoro:masterfrom
Conversation
On a table with flipped geometry (where row zero is the bottom of the table) each of the cells usually also have flipped geometry to ensure the UI renders correctly. The `imageFromView` wasn't taking this into account so I've cached the `geometryFlipped` value on the cell so that we can render the image with the natural geometry.
…fter the screenshot is taken
Fix flipped tableviewcell bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a table with flipped geometry (where row zero is the bottom of the table) each of the cells usually also have flipped geometry to ensure the UI renders correctly. The
imageFromViewwasn't taking this into account so I've cached thegeometryFlippedvalue on the cell so that we can render the image with the natural geometry.