Chore: [AEA-6258] - Remove exports that aren't necessary at the construct level#647
Merged
Chore: [AEA-6258] - Remove exports that aren't necessary at the construct level#647
Conversation
Contributor
|
This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket: AEA-6258 |
wildjames
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes automatic CloudFormation exports from SsmParametersConstruct, shifting responsibility for exports to higher-level stacks/constructs rather than doing it by default within the construct.
Changes:
- Removed
CfnOutputexports for individual parameter names and the managed policy ARN fromSsmParametersConstruct. - Updated the construct tests to stop asserting exported outputs and instead assert created resources/default policy description.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| packages/cdkConstructs/src/constructs/SsmParametersConstruct.ts | Removes CfnOutput usage so the construct no longer creates CloudFormation Outputs/Exports. |
| packages/cdkConstructs/tests/constructs/ssmParametersConstruct.test.ts | Removes tests asserting exports and updates a defaults test to assert resources/policy description instead. |
packages/cdkConstructs/tests/constructs/ssmParametersConstruct.test.ts
Outdated
Show resolved
Hide resolved
packages/cdkConstructs/tests/constructs/ssmParametersConstruct.test.ts
Outdated
Show resolved
Hide resolved
|
anthony-nhs
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
The export of a parameter is not needed in all cases - it should be handled higher up the hierarchy, rather than doing it by default at the construct level every time.