Skip to content

Add mac latest back into the mix after ordering issues have (hopefully) been solved#1383

Draft
brtietz wants to merge 5 commits intodevelopfrom
reenable_mac_runner
Draft

Add mac latest back into the mix after ordering issues have (hopefully) been solved#1383
brtietz wants to merge 5 commits intodevelopfrom
reenable_mac_runner

Conversation

@brtietz
Copy link
Copy Markdown
Collaborator

@brtietz brtietz commented Apr 6, 2026

Pull Request Template

Description

Now that we've fixed more issues that were identified in #1354, re-enable the mac-latest runner

Corresponding branches and PRs:

N/A

Unit Test Impact:

Hopefully everything passes, otherwise we might have more PRs prior to getting this runner enabled

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

@brtietz brtietz added this to the SAM 2026 Release milestone Apr 6, 2026
@brtietz brtietz requested review from dguittet and sjanzou April 6, 2026 15:43
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 6, 2026

Coverage Report for CI Build 24365602681

Coverage increased (+0.02%) to 56.3%

Details

  • Coverage increased (+0.02%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 13 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

13 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
or-tools-9.14/install_release/include/eigen3/Eigen/src/Core/util/Memory.h 13 48.2%

Coverage Stats

Coverage Status
Relevant Lines: 121123
Covered Lines: 68192
Line Coverage: 56.3%
Coverage Strength: 3453238.27 hits per line

💛 - Coveralls

Copy link
Copy Markdown
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please download the arm64 version of or-tools for the "macos-latest" runner

if: steps.cached-ortools-restore.outputs.cache-hit != 'true'
shell: bash
run: |
curl -L https://github.com/google/or-tools/releases/download/v$ORTOOLS_VER/or-tools_x86_64_macOS-15.5_cpp_v$ORTOOLS_VER.$ORTOOLS_RELEASE.tar.gz -o or-tools-$ORTOOLS_VER.tar.gz
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be the arm64 version for macos-latest...

@brtietz
Copy link
Copy Markdown
Collaborator Author

brtietz commented Apr 13, 2026

Failing tests on the latest build:

[ FAILED ] 4 tests, listed below:
[ FAILED ] CMPvsamv1BatteryIntegration_cmod_pvsamv1.ResidentialDCBatteryModelPriceSignalDispatchGridExport
[ FAILED ] CMPvsamv1PowerIntegration_cmod_pvsamv1.NoFinancialModelSkyDiffuseAndIrradModels
[ FAILED ] SCO2Design.partial_default
[ FAILED ] AutoBTMTest_lib_battery_dispatch.TestSummerPeakGridCharging

Potentially more memory issues to clean up?

@brtietz brtietz marked this pull request as draft April 13, 2026 21:28
@sjanzou
Copy link
Copy Markdown
Collaborator

sjanzou commented Apr 14, 2026

Failing tests on the latest build:

[ FAILED ] 4 tests, listed below:
[ FAILED ] CMPvsamv1BatteryIntegration_cmod_pvsamv1.ResidentialDCBatteryModelPriceSignalDispatchGridExport
[ FAILED ] CMPvsamv1PowerIntegration_cmod_pvsamv1.NoFinancialModelSkyDiffuseAndIrradModels
[ FAILED ] SCO2Design.partial_default
[ FAILED ] AutoBTMTest_lib_battery_dispatch.TestSummerPeakGridCharging

Potentially more memory issues to clean up?

Tests are failing but are close, e.g.
image

I agree that memory leakage could be an issue - especially if rerunning the tests give different results!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants