Open
Conversation
dsarrut
force-pushed
the
coresi_ccmod
branch
from
d2942e8 to
79c195f
Compare
dsarrut
force-pushed
the
coresi_ccmod
branch
from
82b6b16 to
49747ee
Compare
ZainaHurani
force-pushed
the
coresi_ccmod
branch
from
a58cc4e to
5520183
Compare
This was referenced Mar 19, 2026
…functions with initial test implementation
…rameter, and improve readability
…s.py, and update test097 for multi-camera setup
defined PCB material used in the geometry.
Updated MACACO1 camera configuration with new components and sizes.
Thanks for the review! I updated the default camera position to be at the world center, as suggested and fixed the coordinate of pcb_scatt. For the material, I checked the G4 files and it's not the same at all, I'm not sure why I used it in my code before, so I fixed it here and on vs.
… in macaco camera simulation
… simulation singles
Added a function to merge scatterer and absorber singles, run the Gate coincidence sorter, and filter good coincidences.
…ve_branches is given to the function. Warning at the end if in the merged file the branches requied for sorting the singles are not present
…mprove parameterization, add plot generation for Gaussian peak comparisons, and fix inconsistencies in camera initialization.
…idences.py`; remove obsolete `coinc_filters.py` and `merge_coinc.py`.
…nce validation workflow, clarify comments, and enhance function readability.
…nce validation workflow, clarify comments, and enhance function readability.
…in MACACO1 test script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.