Skip to content

Fix NY inflation refund credit to use 2023 tax year#7927

Draft
PavelMakarchuk wants to merge 3 commits intomainfrom
ny-inflation-refund-year-fix
Draft

Fix NY inflation refund credit to use 2023 tax year#7927
PavelMakarchuk wants to merge 3 commits intomainfrom
ny-inflation-refund-year-fix

Conversation

@PavelMakarchuk
Copy link
Copy Markdown
Collaborator

Summary

Fixes the NY inflation refund credit to be based on the 2023 tax year instead of 2025, per the NY Tax Department.

Closes #7902

Root Cause

The credit was modeled with formula_2025 and included in the 2025 refundable credits list, but the actual program uses 2023 tax year returns (Form IT-201 line 33 NY AGI). Checks were mailed based on 2023 data, not claimed on the 2025 IT-201.

Changes

  • formula_2025formula_2023, formula_2026formula_2024
  • Moved ny_inflation_refund_credit from 2025 to 2023 entry in refundable.yaml
  • Removed the now-unnecessary 2026 entry from refundable.yaml
  • Updated all tests to use period: 2023
  • Added test confirming credit is zero in 2025

Test plan

  • 14 tests covering all filing statuses, income tiers, out-of-state, and year boundaries (2022, 2023, 2024, 2025)
  • CI passes

🤖 Generated with Claude Code

The NY inflation refund was based on 2023 tax returns per the NY Tax
Department, not 2025. This fix:

- Changes formula_2025 → formula_2023, formula_2026 → formula_2024
- Moves ny_inflation_refund_credit from 2025 to 2023 in refundable.yaml
- Removes the now-unnecessary 2026 entry from refundable.yaml
- Updates all tests to use period 2023
- Adds test confirming credit is zero in 2025

Closes #7902

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d95d3cd) to head (d95b1d0).
⚠️ Report is 129 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main     #7927    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           19         1    -18     
  Lines          297        19   -278     
==========================================
- Hits           297        19   -278     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

PavelMakarchuk and others added 2 commits April 6, 2026 10:48
Aligns with the original pattern: formula (catch-all) + formula_2023
(calculation) + formula_2024 (returns 0).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The statute assigns the credit to tax year 2025 ("a credit against
the taxes imposed by this article... for tax year two thousand
twenty-five"), even though eligibility is determined using 2023 data.

Reverts the year change but keeps improvements:
- Added reference to NY Tax Department page
- Updated label
- Added comment documenting the 2023-eligibility/2025-credit distinction
- Added test comment explaining the cross-year limitation

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ny_inflation_refund_credit assigned to wrong tax year (2025 instead of 2023)

1 participant