Fix NY inflation refund credit to use 2023 tax year#7927
Draft
PavelMakarchuk wants to merge 3 commits intomainfrom
Draft
Fix NY inflation refund credit to use 2023 tax year#7927PavelMakarchuk wants to merge 3 commits intomainfrom
PavelMakarchuk wants to merge 3 commits intomainfrom
Conversation
The NY inflation refund was based on 2023 tax returns per the NY Tax Department, not 2025. This fix: - Changes formula_2025 → formula_2023, formula_2026 → formula_2024 - Moves ny_inflation_refund_credit from 2025 to 2023 in refundable.yaml - Removes the now-unnecessary 2026 entry from refundable.yaml - Updates all tests to use period 2023 - Adds test confirming credit is zero in 2025 Closes #7902 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7927 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 19 1 -18
Lines 297 19 -278
==========================================
- Hits 297 19 -278
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Aligns with the original pattern: formula (catch-all) + formula_2023 (calculation) + formula_2024 (returns 0). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The statute assigns the credit to tax year 2025 ("a credit against
the taxes imposed by this article... for tax year two thousand
twenty-five"), even though eligibility is determined using 2023 data.
Reverts the year change but keeps improvements:
- Added reference to NY Tax Department page
- Updated label
- Added comment documenting the 2023-eligibility/2025-credit distinction
- Added test comment explaining the cross-year limitation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the NY inflation refund credit to be based on the 2023 tax year instead of 2025, per the NY Tax Department.
Closes #7902
Root Cause
The credit was modeled with
formula_2025and included in the 2025 refundable credits list, but the actual program uses 2023 tax year returns (Form IT-201 line 33 NY AGI). Checks were mailed based on 2023 data, not claimed on the 2025 IT-201.Changes
formula_2025→formula_2023,formula_2026→formula_2024ny_inflation_refund_creditfrom 2025 to 2023 entry inrefundable.yamlrefundable.yamlperiod: 2023Test plan
🤖 Generated with Claude Code