Skip to content

Pandapower attr enum#409

Open
furqan463 wants to merge 5 commits intoPowerGridModel:mainfrom
furqan463:pandapower_attr_enum
Open

Pandapower attr enum#409
furqan463 wants to merge 5 commits intoPowerGridModel:mainfrom
furqan463:pandapower_attr_enum

Conversation

@furqan463
Copy link
Copy Markdown
Contributor

Fixes #315
as enums are only required for pandapower. json, excel and vision converters do not have raw strings in src files.

Changes proposed in this PR include:

Adds attribute enums for pandapower.

Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
@furqan463
Copy link
Copy Markdown
Contributor Author

Created attr enums by iterating over an empty pandapower network tables and adding all columns to a set then had to enter some manually. However, there are several attr enums that are not being used inside pgm_io. Should we retain the exhaustive enum as it is, are somehow retain only those attributes that are actually being utilized in pgm_io?.

@figueroa1395
Copy link
Copy Markdown
Member

Hello @furqan463,

Thanks for the contribution. At the moment we are a bit occupied, so we expect to review and give feedback sometime next week.

@figueroa1395 figueroa1395 added the feature New feature or request label Apr 10, 2026
Signed-off-by: furqan463 <ahmadfurqanc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Enums for "external" components

2 participants