Add fast skip pre-check to avoid loading full datasets for up-to-date entries#73
Merged
Add fast skip pre-check to avoid loading full datasets for up-to-date entries#73
Conversation
… entries
Before processing batches, loads a lightweight {identifier_key: last_modified_at}
dict from the database in a single query (no joins to revision/file tables).
Datasets where last_modified_at >= max(file.last_modified) are skipped instantly
without the expensive get_dataset_collection call.
The cache is built once per (provider, dataset_type) in the loader and reused
across selectors within the same run.
No false negatives: datasets that might need updating always fall through to
the full should_refetch check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before processing batches, loads a lightweight {identifier_key: last_modified_at} dict from the database in a single query (no joins to revision/file tables). Datasets where last_modified_at >= max(file.last_modified) are skipped instantly without the expensive get_dataset_collection call.
The cache is built once per (provider, dataset_type) in the loader and reused across selectors within the same run.
No false negatives: datasets that might need updating always fall through to the full should_refetch check.