Add Q10 remote control trait#812
Closed
Kraina68512 wants to merge 5 commits intoPython-roborock:mainfrom
Closed
Conversation
allenporter
requested changes
Apr 9, 2026
|
|
||
| from .command import CommandTrait | ||
|
|
||
| REMOTE_COMMANDS = { |
Contributor
There was a problem hiding this comment.
I think this could be an enum
Author
There was a problem hiding this comment.
where should I put the class? cause i cant do it into the remote trait file
Contributor
There was a problem hiding this comment.
Seems fine where you put it. I do think it could go in the remote trait file, so not sure why that didn't work for you.
Author
|
I tthink i did it |
allenporter
approved these changes
Apr 10, 2026
allenporter
requested changes
Apr 10, 2026
Contributor
allenporter
left a comment
There was a problem hiding this comment.
Tests and lint are failing
Author
|
really sorry i gonna open this request when i get how to normally use git in visual studio (never used before) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the b01_q10_properties of devices have "remote" trait, that allows you to control your roborock faster, and, maybe, smoother
Simple usage:
btw there is no "backward" command