Refactor cost access behind accessor object#804
Open
nathanneike wants to merge 1 commit intoPythonOT:masterfrom
Open
Refactor cost access behind accessor object#804nathanneike wants to merge 1 commit intoPythonOT:masterfrom
nathanneike wants to merge 1 commit intoPythonOT:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #804 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 113 113
Lines 23062 23062
=======================================
Hits 22342 22342
Misses 720 720 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and context / Related issue
This PR cleans up cost handling in the network simplex solver by introducing a dedicated cost accessor object. The goal is to centralize cost retrieval for the different existing cost modes instead of keeping the logic duplicated across pricing, initialization, warmstart, and total-cost computation.
This does not aim to change solver behavior. It is a cleanup step to make the cost path easier to reason about and easier to extend in follow-up optimization work.
How has this been tested (if it applies)
clang:CC=clang CXX=clang++ LDFLAGS="-L$PWD/.openmp/lib -Wl,-rpath,$PWD/.openmp/lib -lomp" .venv/bin/python setup.py build_ext --inplacePR checklist