Skip to content

Let user know when CMAKE_CXX_FLAGS are being ignored. #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stefanatwork wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Let user know when CMAKE_CXX_FLAGS are being ignored. #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e314eda
Warn user when CMAKE_CXX_FLAGS are being ignored.
stefanatwork Jun 11, 2025
c55d0e4
Merge branch 'master' into sw/ignore_cxx_flags_message
stefanatwork Jun 12, 2025
af27317
Merge branch 'master' into sw/ignore_cxx_flags_message
stefanatwork Jun 16, 2025
0801113
Merge branch 'master' into sw/ignore_cxx_flags_message
stefanatwork Feb 3, 2026
cf0dfa8
Merge branch 'master' into sw/ignore_cxx_flags_message
stefanatwork Feb 5, 2026
2c366de
Merge branch 'master' into sw/ignore_cxx_flags_message
stefanatwork Apr 13, 2026
9fbce4f
Update common/cmake/intel.cmake
stefanatwork Apr 14, 2026
3b7e22e
Update common/cmake/clang.cmake
stefanatwork Apr 14, 2026
a2d6807
Update common/cmake/gnu.cmake
stefanatwork Apr 14, 2026
efb7054
Update common/cmake/dpcpp.cmake
stefanatwork Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion common/cmake/clang.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,10 @@ ELSE()

OPTION(EMBREE_IGNORE_CMAKE_CXX_FLAGS "When enabled Embree ignores default CMAKE_CXX_FLAGS." ON)
OPTION(EMBREE_ADDRESS_SANITIZER "Enabled CLANG address sanitizer." OFF)
IF (EMBREE_IGNORE_CMAKE_CXX_FLAGS)
IF(EMBREE_IGNORE_CMAKE_CXX_FLAGS)
IF(CMAKE_CXX_FLAGS)
MESSAGE(WARNING "Ignoring CMAKE_CXX_FLAGS because EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled. Configure with EMBREE_IGNORE_CMAKE_CXX_FLAGS=OFF to honor CMAKE_CXX_FLAGS. Ignored value: '${CMAKE_CXX_FLAGS}'")
ENDIF()
SET(CMAKE_CXX_FLAGS "")
ENDIF()

Expand Down
5 changes: 4 additions & 1 deletion common/cmake/dpcpp.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ _SET_IF_EMPTY(FLAGS_AVX512 "-march=skx")

IF (NOT WIN32)
OPTION(EMBREE_IGNORE_CMAKE_CXX_FLAGS "When enabled Embree ignores default CMAKE_CXX_FLAGS." ON)
IF (EMBREE_IGNORE_CMAKE_CXX_FLAGS)
IF(EMBREE_IGNORE_CMAKE_CXX_FLAGS)
IF(CMAKE_CXX_FLAGS)
MESSAGE(WARNING "Ignoring CMAKE_CXX_FLAGS because EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled. Configure with -DEMBREE_IGNORE_CMAKE_CXX_FLAGS=OFF to honor CMAKE_CXX_FLAGS. Ignored value: ${CMAKE_CXX_FLAGS}")
ENDIF()
SET(CMAKE_CXX_FLAGS "")
ENDIF()
ENDIF()
Expand Down
5 changes: 4 additions & 1 deletion common/cmake/gnu.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ ELSE ()
ENDIF ()

OPTION(EMBREE_IGNORE_CMAKE_CXX_FLAGS "When enabled Embree ignores default CMAKE_CXX_FLAGS." ON)
IF (EMBREE_IGNORE_CMAKE_CXX_FLAGS)
IF(EMBREE_IGNORE_CMAKE_CXX_FLAGS)
IF(CMAKE_CXX_FLAGS)
MESSAGE(WARNING "Ignoring CMAKE_CXX_FLAGS because EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled. Configure with -DEMBREE_IGNORE_CMAKE_CXX_FLAGS=OFF to honor CMAKE_CXX_FLAGS. Ignored value: '${CMAKE_CXX_FLAGS}'.")
ENDIF()
SET(CMAKE_CXX_FLAGS "")
ENDIF()

Expand Down
5 changes: 4 additions & 1 deletion common/cmake/intel.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,10 @@ ELSE()
_SET_IF_EMPTY(FLAGS_AVX512 "-xCORE-AVX512")

OPTION(EMBREE_IGNORE_CMAKE_CXX_FLAGS "When enabled Embree ignores default CMAKE_CXX_FLAGS." ON)
IF (EMBREE_IGNORE_CMAKE_CXX_FLAGS)
IF(EMBREE_IGNORE_CMAKE_CXX_FLAGS)
IF(CMAKE_CXX_FLAGS)
MESSAGE(WARNING "Ignoring CMAKE_CXX_FLAGS because EMBREE_IGNORE_CMAKE_CXX_FLAGS is enabled. Configure with -DEMBREE_IGNORE_CMAKE_CXX_FLAGS=OFF to honor CMAKE_CXX_FLAGS. Ignored value: '${CMAKE_CXX_FLAGS}'.")
ENDIF()
SET(CMAKE_CXX_FLAGS "")
ENDIF()

Expand Down
Loading