Open
Conversation
ReferenceGenerator.ReadCMXText() was taking longer than expected, and Visual Studio's profiler was showing the "new char[blockSize / 2]" line of ReadUTF16String() to be taking the majority of the time. This was caused by PSO2Text asking to read the entire remaining data in the file every time it needed to read a string. Letting it use the default read size and just keep doing more reads if it didn't find the end of the string is significantly faster. Also improved ReadUTF16String() to replace an intermediate string allocation with a span. Together, these reduce ReferenceGenerator.ReadCMXText() from 8-10 seconds to about 0.7 seconds on my machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReferenceGenerator.ReadCMXText() was taking longer than expected, and Visual Studio's profiler was showing the "new char[blockSize / 2]" line of ReadUTF16String() to be taking the majority of the time. This was caused by PSO2Text asking to read the entire remaining data in the file every time it needed to read a string. Letting it use the default read size and just keep doing more reads if it didn't find the end of the string is significantly faster.
Also improved ReadUTF16String() to replace an intermediate string allocation with a span.
Together, these reduce ReferenceGenerator.ReadCMXText() from 8-10 seconds to about 0.7 seconds on my machine.