add multiir_motion_MIR-IR100#2861
add multiir_motion_MIR-IR100#2861thinkaName wants to merge 1 commit intoSmartThingsCommunity:mainfrom
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 72 files 500 suites 0s ⏱️ Results for commit 3b5d613. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3b5d613 |
thinkaName
force-pushed
the
multiir_motion_MIR-IR100
branch
from
6681b2e to
3b5d613
Compare
cjswedes
left a comment
cjswedes
left a comment
There was a problem hiding this comment.
All of the files added have the executable permission included. They should not. Please re-add them with only read/write permissions. I tested out this and you can do it with git update-index --chmod=-x <file_path> for all the files you have added.
| local function do_configure(self, device) | ||
| device:configure() | ||
| end |
There was a problem hiding this comment.
The default doConfigure handler calls device:configure() and injects a refresh capability command. You should not override this handler and use the default.
| local zcl_messages = require "st.zigbee.zcl" | ||
| local messages = require "st.zigbee.messages" | ||
| local zb_const = require "st.zigbee.constants" | ||
| local read_attribute = require "st.zigbee.zcl.global_commands.read_attribute" |
There was a problem hiding this comment.
Never used. Remove so this passes the luacheck CI step.
| local FrameCtrl = require "st.zigbee.zcl.frame_ctrl" | ||
|
|
||
| test.add_package_capability("sensitivityAdjustment.yaml") | ||
| test.add_package_capability("detectionFrequency.yaml") |
There was a problem hiding this comment.
This is not a capability on the profile, it is a preference. I think this can be removed.
| - id: battery | ||
| version: 1 | ||
| - id: refresh | ||
| version: 1 |
There was a problem hiding this comment.
This should have the FW update capability.
2 participants
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests