add MultiIR Smoke Detector MIR-SM200#2874
add MultiIR Smoke Detector MIR-SM200#2874thinkaName wants to merge 1 commit intoSmartThingsCommunity:mainfrom
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 72 files 500 suites 0s ⏱️ Results for commit e509e7b. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against e509e7b |
thinkaName
force-pushed
the
multiir_smoke_detector_MIR_SM200
branch
from
0fbd389 to
d907021
Compare
thinkaName
force-pushed
the
multiir_smoke_detector_MIR_SM200
branch
from
d907021 to
e509e7b
Compare
| } | ||
| ) | ||
|
|
||
| test.run_registered_tests() No newline at end of file |
There was a problem hiding this comment.
nit: add newline to EOF
| local function do_configure(self, device) | ||
| device:configure() | ||
| end |
There was a problem hiding this comment.
The defaults cover this and inject a refresh command. You should remove it and use the default.
| local function ias_zone_status_attr_handler(driver, device, zone_status, zb_rx) | ||
| generate_event_from_zone_status(driver, device, zone_status, zb_rx) | ||
| end |
There was a problem hiding this comment.
| local function ias_zone_status_attr_handler(driver, device, zone_status, zb_rx) | |
| generate_event_from_zone_status(driver, device, zone_status, zb_rx) | |
| end |
This function is unnecessary. Use generate_event_from_zone_status directly in the driver template for the IASZone.attributes.ZoneStatus.ID handler.
| zigbee_test_utils.prepare_zigbee_env_info() | ||
|
|
||
| local function test_init() | ||
| test.mock_device.add_test_device(mock_device) |
There was a problem hiding this comment.
| test.mock_device.add_test_device(mock_device) | |
| test.mock_device.add_test_device(mock_device) |
| if zone_status:is_alarm1_set() then | ||
| device:emit_event(capabilities.smokeDetector.smoke.detected()) | ||
| elseif zone_status:is_alarm2_set() then | ||
| device:emit_event(capabilities.smokeDetector.smoke.tested()) |
There was a problem hiding this comment.
For ZoneStatus attribute bitmap, I see the following in the spec for bits that can be set:
Is the alarm2 bit corresponding to the test functionality just the way the device works? Do we need to also be considering the test mode bit?
|
All new files are executable, and should be updated to be only read/write |
3 participants
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests