Fix type of HookedTransformerConfig.device#1230
Open
brendanlong wants to merge 1 commit intoTransformerLensOrg:mainfrom
Open
Fix type of HookedTransformerConfig.device#1230brendanlong wants to merge 1 commit intoTransformerLensOrg:mainfrom
brendanlong wants to merge 1 commit intoTransformerLensOrg:mainfrom
Conversation
7 tasks
brendanlong
commented
Apr 3, 2026
brendanlong
force-pushed
the
brendanlong/device-type
branch
from
a36f23e to
7173dfa
Compare
This is typed as `Optional[str]` but sometimes returns `torch.device`. Updated the code to just return the `str` instead of wrapping with a device. I'm not confident that every function which takes a device will always be passed a string, so I didn't change functions like warn_if_mps. Found while working on TransformerLensOrg#1219
brendanlong
force-pushed
the
brendanlong/device-type
branch
from
7173dfa to
560ec23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is typed as
Optional[str]but sometimes returnstorch.device.Updated the code to just return the
strinstead of wrapping with adevice.
I'm not confident that every function which takes a device will
always be passed a string, so I didn't change functions like
warn_if_mps.
Found while working on #1219.
Type of change
Please delete options that are not relevant.
Checklist: