CHANGE: Remove 32-bit compilation check for HID on Windows players#2403
CHANGE: Remove 32-bit compilation check for HID on Windows players#2403jfreire-unity wants to merge 1 commit intodevelopfrom
Conversation
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
| @@ -11,11 +11,6 @@ | |||
| using UnityEngine.Scripting; | |||
| using UnityEngine.Pool; | |||
|
|
|||
There was a problem hiding this comment.
The #warning regarding the lack of HID support for 32-bit Windows standalone players has been removed. Could you confirm if this platform is now fully supported? If the limitation still exists, removing this diagnostic warning without an alternative notice might lead to difficult-to-debug issues for users targeting x86 Windows.
🤖 Helpful? 👍/👎
|
Added something more to QA section of PR description |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2403 +/- ##
===========================================
+ Coverage 77.92% 78.11% +0.19%
===========================================
Files 482 483 +1
Lines 97755 98784 +1029
===========================================
+ Hits 76175 77170 +995
- Misses 21580 21614 +34 Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test_plan |
Test Plan
Summary of Changes & Risk AssessmentSummary of ChangesThis PR removes a legacy compilation check and warning in HID.cs:L15-L19 that flagged HID support as broken for 32-bit Windows standalone players. The check is being removed because Risk Assessment
Test ScenariosFunctional Testing
Regression Testing
🔍 Regression Deep Dive (additional risks identified)
Edge Cases
💡 This test plan updates automatically when 🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr |
2 participants
Description
This removes a compilation check for Windows 32-bit players regarding HID not being supported.
I built with a Windows 32-bit player with U6.x version and the warning was not raised when building so I assume it's not doing anything anymore.
I found this issue when moving this code to trunk becase UNITY_64 is not available at the point the modules are compiled.
I was also told this might be a old legacy check so let's see what QA does.
If this works, we can close https://jira.unity3d.com/browse/ISX-2543
Testing status & QA
I only tested building a sample on Windows 11 but selecting Windows 32-bit architecture on "Build Profile" settings view.
Test plan
We should test HID devices such as Dualsense, Dualshock, Xbox and potentially Nintendo Switch Pro controller work fine for Windows 32-bit standalone players.
OS versions to be tested:
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
We should test HID devices such as Dualsense, Dualshock, Xbox and potentially Nintendo Switch Pro controller work fine for Windows 32-bit standalone players.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.