@actions/glob: extend hashFiles options#2357
Open
priyagupta108 wants to merge 3 commits intoactions:mainfrom
Open
@actions/glob: extend hashFiles options#2357priyagupta108 wants to merge 3 commits intoactions:mainfrom
priyagupta108 wants to merge 3 commits intoactions:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Extends @actions/glob’s hashFiles to allow hashing files outside the workspace in a safer, more configurable way (root allowlist + opt-in outside-root inclusion + exclude patterns), addressing the limitations described in #1035.
Changes:
- Add
HashFileOptionsfields:roots,allowFilesOutsideWorkspace, andexclude. - Update
internal-hash-filesto enforce root allowlisting using realpaths (symlink-safe) and support exclude filtering + outside-root warnings. - Add test coverage and README documentation for the new options.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/glob/src/internal-hash-files.ts | Implements root allowlist checks, exclude pattern matching, and outside-root behavior/warnings. |
| packages/glob/src/internal-hash-file-options.ts | Adds new public hashFiles options to the HashFileOptions interface. |
| packages/glob/src/glob.ts | Wires the new options through to the internal hasher. |
| packages/glob/tests/hash-files.test.ts | Adds tests for roots filtering, opt-in outside-root hashing, and exclude patterns. |
| packages/glob/README.md | Documents hashFiles behavior and the newly added options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request extends
@actions/globhashFilesto support safer and more flexible hashing by adding options for allowedroots, an opt-in to include files outside those roots (allowFilesOutsideWorkspace), and exclude patterns (exclude).Closes #1035