Fixed param ordering in the media analytics bridge for createAdBreakObject, createChapterObject, and createQoEObject methods#1476
Open
Fixed param ordering in the media analytics bridge for createAdBreakObject, createChapterObject, and createQoEObject methods#1476
Conversation
…param ordering for createAdBreakObject, createChapterObject, and createQoEObject methods
🦋 Changeset detectedLatest commit: f7ecc09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
Closes #1472 |
carterworks
approved these changes
Apr 2, 2026
| value: "hello", | ||
| }, | ||
| ]); | ||
| /* |
Collaborator
There was a problem hiding this comment.
either uncomment or remove this block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After getting #1473, I decided to audit the entire media analytics bridge API. I found two other methods with switched params, and it was missing the version property.
createAdBreakObject - args 2 & 3 swapped (position & startTime)
createChapterObject - args 2 & 4 swapped (position & startTime)
createQoEObject - args 2 & 4 swapped (startupTime & droppedFrames)
version - version property was missing, now is just the Web SDK version (i.e. "WEBSDK 2.30.0")
Related Issue
Motivation and Context
Screenshots (if appropriate):
Checklist:
pnpm changeset) or it is not necessary because this PR is not consumer-facing.