fix: skip blank/whitespace lines in receive loop#87
Open
aorumbayev wants to merge 1 commit intoagentclientprotocol:mainfrom
Open
fix: skip blank/whitespace lines in receive loop#87aorumbayev wants to merge 1 commit intoagentclientprotocol:mainfrom
aorumbayev wants to merge 1 commit intoagentclientprotocol:mainfrom
Conversation
aorumbayev
force-pushed
the
fix/skip-blank-lines-in-receive-loop
branch
from
8614b96 to
8de3d9c
Compare
_receive_loop only checked for EOF (b""), but blank lines like b"\n" or b"\r\n" are truthy and reached json.loads(), causing JSONDecodeError. Strip each line and skip when empty before parsing.
aorumbayev
force-pushed
the
fix/skip-blank-lines-in-receive-loop
branch
from
8de3d9c to
26e3fc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Blank/whitespace-only lines (
\n,\r\n,\n) in the stream are valid no-ops in newline-delimited JSON framing but currently reachjson.loads()and trigger a fulllogging.exception()traceback at ERROR level. This is noisy in production — especially on WSL where Windows-native agent subprocesses commonly emit\r\nblanks.Strip each line and skip when empty before parsing. Adds a regression test.