Fix process group termination: always send SIGKILL after SIGTERM#151
Open
TravisRiveraPetit wants to merge 2 commits intomainfrom
Open
Fix process group termination: always send SIGKILL after SIGTERM#151TravisRiveraPetit wants to merge 2 commits intomainfrom
TravisRiveraPetit wants to merge 2 commits intomainfrom
Conversation
maltehelmert
reviewed
Apr 7, 2026
| os.killpg(os.getpgid(self.process.pid), signal.SIGKILL) | ||
|
|
||
| with contextlib.suppress(OSError, ProcessLookupError): | ||
| os.killpg(pgid, signal.SIGKILL) |
Contributor
There was a problem hiding this comment.
What's the rationale for this change? I don't think it's good style to kill a process that we know has terminated. Is poll not reliable? If the process has terminated, it will be in zombie state here. Better to have it finish normally than kill it, I would say, if it has terminated in the one-second grace period.
Author
There was a problem hiding this comment.
The problem is that we are currently using poll() on the leader process as a proxy for whether the whole process group has terminated.
Before, if the leader spawned child processes, it could happen that the leader exited after SIGTERM while some children were still running. In that case, poll() would return the leader’s exit code rather than None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue in Call._terminate_process_group where SIGKILL was only sent if the parent process was still alive.