update mean reduction zloss to ignore labels == ignore_index #760
Open
jasonkrone wants to merge 3 commits intoallenai:mainfrom
Open
update mean reduction zloss to ignore labels == ignore_index #760jasonkrone wants to merge 3 commits intoallenai:mainfrom
jasonkrone wants to merge 3 commits intoallenai:mainfrom
Conversation
dirkgr
approved these changes
Feb 4, 2025
Contributor
dirkgr
left a comment
dirkgr
left a comment
There was a problem hiding this comment.
This is good. Thank you! Can you update the changelog, and we're good to go?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reduction == "mean", the current implementation sets the z_squared values to 0 vs. ignoring them. These 0 values impact the number of element in the mean reduction and therefore the final z-loss.
Perhaps this is intentional, but just in case it's not, I made a quick PR to ignore the values vs. setting them to 0.