build: move TypeScript and Angular Compiler CLI to dependencies#32977
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Apr 10, 2026
Merged
build: move TypeScript and Angular Compiler CLI to dependencies#32977alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
alan-agius4
added
the
action: review
angular-robot
bot
added
the
area: build & ci
alan-agius4
added
target: minor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request moves @angular/compiler-cli and typescript from devDependencies to dependencies in package.json, with corresponding updates to the pnpm-lock.yaml file. Feedback indicates that @angular/compiler should also be moved to the dependencies section to satisfy the peer dependency requirements of @angular/compiler-cli and prevent potential installation failures in production environments.
This is needed by rules_angular as otherwise these two packages are not present in the `npm_package_store_infos` using in the symlink package.
alan-agius4
force-pushed
the
symlink-main
branch
from
c17d0b9 to
6371e2f
Compare
angular-robot
bot
added
the
area: build & ci
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed by rules_angular as otherwise these two packages are not present in the
npm_package_store_infosusing in the symlink package.See: https://github.com/alan-agius4/dev-infra/blob/6cd21db3992d23e5a8009d5379723a487214e092/bazel/rules/rules_angular/src/private/symlink_package.bzl#L24