FINERACT-2454: Migrate ClientLoanAccountLockIntegrationTest from RestAssured to feign client

[Dpk376]

Description

Relates to FINERACT-2454

Migrates ClientLoanAccountLockIntegrationTest from RestAssured to the type-safe feign client.

Changes

• Replaced RequestSpecification/ResponseSpecification boilerplate with extends BaseLoanIntegrationTest
• Removed @BeforeEach setup, clientHelper, loanTransactionHelper, loanAccountLockHelper instance fields
• Replaced ClientHelper.createClient(requestSpec, responseSpec) → ClientHelper.addClientAsPerson()
• Replaced LoanProductTestBuilder + getLoanProductId() → createLoanProduct(createOnePeriod30DaysLongNoInterestPeriodicAccrualProduct())
• Replaced LoanApplicationTestBuilder + getLoanId() → applyLoan(applyLoanRequest(...))
• Replaced approveLoan(String, Integer) → approveLoan(Long, PostLoansLoanIdRequest)
• Replaced disburseLoanWithNetDisbursalAmount() → disburseLoan(Long, String, Double)
• Replaced LoanStatusChecker HashMap assertions → verifyLoanStatus(loanId, LoanStatus.*)
• Replaced LoanAccountLockHelper.placeSoftLockOnLoanAccount() (RestAssured) → FineractClientHelper.getFineractClient().legacy.placeLockOnLoanAccount() (feign)
• Replaced clientHelper.retrieveLockedAccounts() instance call → FineractClientHelper.getFineractClient().loanAccountLockApi.retrieveLockedAccounts() (feign)

Result

134 lines → 65 lines. Zero RestAssured imports remaining.

No behavioral changes — the test still verifies that a soft-locked loan account appears in the locked accounts list.

[adamsaghy]

Please run:
./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest
./gradlew --no-daemon build -x test -x cucumber -x doc

Before any PR or changes, please always run these two commands and make sure there is green build!

[Dpk376]

Please run: ./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest ./gradlew --no-daemon build -x test -x cucumber -x doc

Before any PR or changes, please always run these two commands and make sure there is green build!

Sure Adam I will be following for this and subsequent PR's. Thank you for the guidance

[adamsaghy]

org.apache.fineract.integrationtests.LoanWithdrawnByApplicantIntegrationTest
  
    Test loanWithdrawnByApplicant() FAILED
  
    org.apache.fineract.client.util.CallFailedRuntimeException: HTTP failed: Request{method=POST, url=https://localhost:8443/fineract-provider/api/v1/clients, tags={class retrofit2.Invocation=org.apache.fineract.client.services.ClientApi.createClient() [class PostClientsRequest {
        activationDate: 01 January 2012
        active: true
        address: null
        datatables: null
        dateFormat: dd MMMM yyyy
        dateOfBirth: null
        emailAddress: null
        externalId: null
        firstname: Gage
        fullname: null
        groupId: null
        lastname: Hayes
        legalFormId: null
        locale: en
        middlename: null
        mobileNo: null
        officeId: 1
    }]}}; Response{protocol=http/1.1, code=400, message=, url=https://localhost:8443/fineract-provider/api/v1/clients}; errorBody: {"developerMessage":"The request was invalid. This typically will happen due to validation errors which are provided.","httpStatusCode":"400","defaultUserMessage":"Validation errors exist.","userMessageGlobalisationCode":"validation.msg.validation.errors.exist","errors":[{"defaultUserMessage":"The parameter `legalFormId` is mandatory.","parameterName":"legalFormId","developerMessage":"The parameter `legalFormId` is mandatory.","userMessageGlobalisationCode":"validation.msg.client.legalFormId.cannot.be.blank","args":[{}]}]}
        at app//org.apache.fineract.integrationtests.LoanWithdrawnByApplicantIntegrationTest.loanWithdrawnByApplicant(LoanWithdrawnByApplicantIntegrationTest.java:33)
  

[Dpk376]

Hi @adamsaghy

Regarding my CI check failure

CI OOMs in :fineract-client-feign:buildJavaSdk when it runs concurrently with :fineract-client:buildJavaSdk; I added a SharedBuildService limiter (maxParallelUsages=1) applied to all OpenAPI GenerateTasks so codegen can’t run concurrently.

Is this fine ?

If you say yes i can push the build.gradle with updated changes . Or can you say any alternatives. Since in my local it is green build

[Dpk376]

Hi @adamsaghy

This PR is ready to merge.

[adamsaghy]

@Dpk376 Please rebase.

[Dpk376]

@Dpk376 Please rebase.

Hi @adamsaghy

Rebased on latest develop and resolved the conflicts. Ran all quality checks (spotless, spotbugs, checkstyle) and full build locally - all passing.

Note: CI may occasionally fail with OOM during concurrent buildJavaSdk tasks (:fineract-client:buildJavaSdk and :fineract-client-feign:buildJavaSdk) - this is a known infrastructure issue unrelated to this change. need to re-trigger if it occurs.

Thanks!

[adamsaghy]

@Dpk376 Please rebase this PR with latest develop branch. Many of the checks were skipped due to incorrect dependency in Github Actions CI jobs!

[Dpk376]

@Dpk376 Please rebase this PR with latest develop branch. Many of the checks were skipped due to incorrect dependency in Github Actions CI jobs!

---

Hi @adamsaghy,

Rebased onto latest develop (now at 1c59ecb6). The startup_failure on the previous CI run was caused by the gradle/actions bump to v6.1.0 in develop (later reverted in #5746) — my last rebase landed during that broken window. The new CI run should use the restored v5.0.2 and complete fully.

Thanks!

---

[Dpk376]

Hi @adamsaghy

This is a memory issue that occurs when the Java Virtual Machine (JVM) runs out of allocated heap memory while building the Java SDK. That's why 1 check failed rerunning will resolve this

[Dpk376]

Hi @adamsaghy

This is ready for merging . Let me know if anything needed from my side