FINERACT-2455: Working Capital product near breach configuration#5740
Open
alberto-art3ch wants to merge 1 commit intoapache:developfrom
Open
Conversation
alberto-art3ch
force-pushed
the
FINERACT-2455/working-capital-product-near-breach-configuration
branch
5 times, most recently
from
a6f5a4d to
3f5d710
Compare
Contributor
|
@alberto-art3ch please rebase |
alberto-art3ch
force-pushed
the
FINERACT-2455/working-capital-product-near-breach-configuration
branch
from
3f5d710 to
a8de8ab
Compare
Contributor
Author
Done! Please review |
alberto-art3ch
force-pushed
the
FINERACT-2455/working-capital-product-near-breach-configuration
branch
2 times, most recently
from
cfc10f4 to
21f037c
Compare
galovics
requested changes
Apr 9, 2026
Contributor
galovics
left a comment
galovics
left a comment
There was a problem hiding this comment.
Builds are failing, pls fix them.
alberto-art3ch
force-pushed
the
FINERACT-2455/working-capital-product-near-breach-configuration
branch
from
21f037c to
726b5bc
Compare
Contributor
Author
Done! Please review |
alberto-art3ch
force-pushed
the
FINERACT-2455/working-capital-product-near-breach-configuration
branch
from
726b5bc to
e956b9a
Compare
| public class WorkingCapitalNearBreachNotFoundException extends AbstractPlatformResourceNotFoundException { | ||
|
|
||
| public WorkingCapitalNearBreachNotFoundException(final Long breachId) { | ||
| super("error.msg.wcl.breach.not.found", "Working Capital Near Breach with id " + breachId + " was not found.", breachId); |
Contributor
There was a problem hiding this comment.
The error code is the same as for breach. It probably should be error.msg.wcl.near.breach.not.found
| } | ||
|
|
||
| if (this.value != null) { | ||
| final BigDecimal number = BigDecimal.valueOf(Double.parseDouble(this.value.toString())); |
Contributor
There was a problem hiding this comment.
This can be simplified to new BigDecimal(this.value.toString())
| if (nearBreachId != null) { | ||
| final WorkingCapitalBreachData breachData = workingCapitalBreachReadPlatformService.retrieveOne(breachId); | ||
| final WorkingCapitalNearBreachData nearBreachData = workingCapitalNearBreachReadPlatformService.retrieveOne(nearBreachId); | ||
| if (FrequencyTypeUtil.compareFrequencies(nearBreachData.getFrequency(), nearBreachData.getFrequencyType().getCode(), |
Contributor
There was a problem hiding this comment.
Do we support partial updates? If yes, then we are losing this check, because at the beginning we check whether nearBreachIdParamName exists. On a partial update that changes only breachId (to a breach with a shorter frequency), the existing nearBreach on the product is not re-validated.
| private final WorkingCapitalNearBreachReadPlatformService readPlatformService; | ||
|
|
||
| public WorkingCapitalNearBreachRequest validateAndParse(@NotNull final JsonCommand command) { | ||
| final DataValidatorBuilder dataValidator = new DataValidatorBuilder(new ArrayList<>()).resource("workingCapitalBreach.create"); |
Contributor
There was a problem hiding this comment.
I believe should be workingCapitalNearBreach.create
| @Path("{breachId}") | ||
| @Consumes({ MediaType.APPLICATION_JSON }) | ||
| @Produces({ MediaType.APPLICATION_JSON }) | ||
| @Operation(operationId = "retrieveWorkingCapitalNearBreach", summary = "Retrieve Working Capital Breach") |
Contributor
There was a problem hiding this comment.
Missed Near for summary
| @POST | ||
| @Consumes({ MediaType.APPLICATION_JSON }) | ||
| @Produces({ MediaType.APPLICATION_JSON }) | ||
| @Operation(operationId = "createWorkingCapitalNearBreach", summary = "Create Working Capital Breach") |
Contributor
There was a problem hiding this comment.
Missed Near for summary
| @Path("{breachId}") | ||
| @Consumes({ MediaType.APPLICATION_JSON }) | ||
| @Produces({ MediaType.APPLICATION_JSON }) | ||
| @Operation(operationId = "updateWorkingCapitalNearBreach", summary = "Update Working Capital Breach") |
Contributor
There was a problem hiding this comment.
Missed Near for summary
| @Path("{breachId}") | ||
| @Consumes({ MediaType.APPLICATION_JSON }) | ||
| @Produces({ MediaType.APPLICATION_JSON }) | ||
| @Operation(operationId = "deleteWorkingCapitalNearBreach", summary = "Delete Working Capital Breach") |
Contributor
There was a problem hiding this comment.
Missed Near for summary
alberto-art3ch
force-pushed
the
FINERACT-2455/working-capital-product-near-breach-configuration
branch
from
e956b9a to
5ec60de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
User should be able to configure near breach at the product level(similar to Breach configuration), now with the next attributes:
FINERACT-2455
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.