[HOTFIX] FINERACT-HOTFIX: Fix repayment template next unpaid installment amount#5768
Open
shamir92 wants to merge 1 commit intoapache:developfrom
Open
[HOTFIX] FINERACT-HOTFIX: Fix repayment template next unpaid installment amount#5768shamir92 wants to merge 1 commit intoapache:developfrom
shamir92 wants to merge 1 commit intoapache:developfrom
Conversation
Contributor
|
Please sign your commits as described in the CONTRIBUTING.md signing guide. Also, please use the required PR title format |
Signed-off-by: Shamir Husein <shamirhusein@gmail.com>
dd9abba to
40a77b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the repayment transaction template query so it returns the next installment with an outstanding balance instead of always defaulting to the earliest installment.
This was needed because partially paid loans could produce an incorrect repayment template amount when the first matching installment was already fully satisfied. The change reuses the existing due amount expressions in the query ordering, and adds an integration test to verify the repayment template now returns the next unpaid installment amount.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.