Open
Conversation
Contributor
Author
|
@leekeiabstraction PTAL 🙏 |
Contributor
leekeiabstraction
left a comment
leekeiabstraction
left a comment
There was a problem hiding this comment.
TY for the PR, left a comment.
Contributor
Author
|
@leekeiabstraction Ty for the review, yes it's in allowlist, pinned v2 commit 👍 |
Contributor
Author
|
@leekeiabstraction now it should be at the latest tag, ty for spotting |
Contributor
Author
|
fixed uv sync here as well, we don't need to sync two times |
Contributor
Author
|
@leekeiabstraction fixed, would you mind to rerun? |
Contributor
Author
|
Good news, the optimizations works as a charm, but it seems that merged code has a bug in python 3.11, so I prepared a fix #488 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #484
Replace actions/cache with Swatinem/rust-cache to prevent cargo cache eviction across CI workflows.