Remove static ThreadLocal caching in XmlUtils to prevent ClassLoader leaks#2516
Open
jbonofre wants to merge 1 commit intoapache:mainfrom
Open
Remove static ThreadLocal caching in XmlUtils to prevent ClassLoader leaks#2516jbonofre wants to merge 1 commit intoapache:mainfrom
jbonofre wants to merge 1 commit intoapache:mainfrom
Conversation
…leaks The static ThreadLocal fields holding DocumentBuilderFactory, TransformerFactory and SAXParserFactory pin the ClassLoader of the XML provider bundle on long-lived Karaf worker threads. When that bundle is updated or refreshed, the old ClassLoader can never be GC'd, leading to zombie bundles and Metaspace growth. Create fresh factory instances per call instead of caching them. The public API is unchanged. Fixes apache#2278
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static
ThreadLocalfields holdingDocumentBuilderFactory,TransformerFactoryandSAXParserFactorypin the ClassLoader of the XML provider bundle on long-lived Karaf worker threads. When that bundle is updated or refreshed, the old ClassLoader can never be GC'd, causing zombie bundles and Metaspace growth.This patch removes the
ThreadLocalcaching and creates fresh factory instances per call. The public API is unchanged.Fixes #2278