[KARAF-2513] Fix log:tail thread leak on SSH disconnect (backport to 4.4.x)#2519
Open
jbonofre wants to merge 1 commit intoapache:karaf-4.4.xfrom
Open
[KARAF-2513] Fix log:tail thread leak on SSH disconnect (backport to 4.4.x)#2519jbonofre wants to merge 1 commit intoapache:karaf-4.4.xfrom
jbonofre wants to merge 1 commit intoapache:karaf-4.4.xfrom
Conversation
ShellCommand.destroy() was empty, so when an SSH session is closed or times out while log:tail is running, the command thread stays blocked on wait() indefinitely. Each reconnect leaks another thread. Store the Karaf session and command thread as fields and clean them up in destroy() — close the session and interrupt the thread, mirroring what ShellFactoryImpl already does for interactive shells.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #2514 to
karaf-4.4.x.ShellCommand.destroy()which was empty — when an SSH session closes or times out whilelog:tailis running, the command thread stays blocked onwait()indefinitely, leaking a thread on every reconnectdestroy()by closing the session and interrupting the thread (mirroring whatShellFactoryImplalready does for interactive shells)Fix #2513