[Backport 4.4.x] Filter out empty repository entries in feature descriptors#2520
Open
jbonofre wants to merge 1 commit intoapache:karaf-4.4.xfrom
Open
[Backport 4.4.x] Filter out empty repository entries in feature descriptors#2520jbonofre wants to merge 1 commit intoapache:karaf-4.4.xfrom
jbonofre wants to merge 1 commit intoapache:karaf-4.4.xfrom
Conversation
Empty or whitespace-only <repository> elements in feature XML descriptors cause a RuntimeException from pax-url-mvn (NullArgumentException: Repository spec is empty string) during boot feature installation. Both Features.trim() and RepositoryImpl.getRepositories()/ getResourceRepositories() now discard blank entries instead of passing them through to URI creation. (backport of apache#2515)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2515 to karaf-4.4.x branch.
<repository>elements in feature XML descriptors cause aRuntimeExceptionfrom pax-url-mvn (NullArgumentException: Repository spec is empty string) during boot feature installation.Features.trim()now removes empty strings instead of keeping them in the list.RepositoryImpl.getRepositories()andgetResourceRepositories()now filter out blank entries before callingURI.create().