Added a global preference for user settings.xml for Maven projects#9282
Added a global preference for user settings.xml for Maven projects#9282Achal1607 wants to merge 1 commit intoapache:masterfrom
Conversation
|
On a cursory look, seems reasonable to me. @sdedic - any comments? Thanks! |
|
useful feature! I found two issues while testing:
|
| JsonPrimitive newMavenUserSettingsPath = null; | ||
| if (c instanceof JsonPrimitive) { | ||
| newMavenUserSettingsPath = (JsonPrimitive) c; | ||
| } |
There was a problem hiding this comment.
nitpick:
JsonPrimitive newMavenUserSettingsPath = c instanceof JsonPrimitive jp ? jp : null;4f66572 to
39b4c45
Compare
I have fixed both the issues @mbien. Can you please review again? Thanks for pointing it out. |
Fixed project files and profile combo box to reflect custom settings.xml
39b4c45 to
45b9f00
Compare
|
The tests are passing locally, can someone please re-run the tests? |
|
Thanks for this addition, although I'm not sure it fully addresses #4263 Ideally, NetBeans should always match the settings Maven would use. So, settings in global execution options, project configuration, (in v4) project settings, etc. would ideally all work. This seems good as a stopgap solution, but will probably all need a rethink when we come to upgrading to Maven 4. |
Added a new preference in the MavenSettings for custom user
settings.xmlfile.Also, exposed it to the LSP
Below is the screenshot for the new preference Netbeans IDE UI:
Closes #4263